Re: pgbench internal contention - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgbench internal contention
Date
Msg-id 25472.1312212419@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgbench internal contention  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> If I'm reading the code right, it only modifies __libc_drand48_data on
> first call, so as long as we called erand48() at least once before
> spawning the child threads, it would probably work.  That seems pretty
> fragile in the face of the fact that they explicitly state that
> they're modifying the global random generator state and that you
> should use erand48_r() if you want reentrant behavior.  So I think if
> we're going to go the erand48() route we probably ought to force
> pgbench to always use our version rather than any OS-supplied version.

Or add erand48_r() to our version and use that.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: lazy vxid locks, v3
Next
From: Simon Riggs
Date:
Subject: Re: Hot standby and GiST page splits (was Re: WIP: Fast GiST index build)