Re: Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot()
Date
Msg-id 25386.1558143007@sss.pgh.pa.us
Whole thread Raw
In response to Re: Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot()  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
David Rowley <david.rowley@2ndquadrant.com> writes:
> On Sat, 18 May 2019 at 12:49, Andres Freund <andres@anarazel.de> wrote:
>> Unless somebody else presses back hard against doing so *soon*, I'm
>> going to close this open issue. I don't think it's worth spending
>> further time arguing about a few characters.

> I'd say if we're not going to bother removing the unused param that
> there's not much point in renaming the function.

FWIW, I'm on the side of "we shouldn't change this".  There's lots of
unused parameters in PG functions, and in most of those cases the API
is reasonable as it stands.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: describe working as intended?
Next
From: Ashutosh Sharma
Date:
Subject: Re: Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot()