Re: [PATCHES] Cygwin PostgreSQL ESQL Patch - Mailing list pgsql-cygwin

From Tom Lane
Subject Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Date
Msg-id 25282.988906546@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Cygwin PostgreSQL ESQL Patch  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [PATCHES] Cygwin PostgreSQL ESQL Patch  (Jason Tishler <Jason.Tishler@dothill.com>)
List pgsql-cygwin
Peter Eisentraut <peter_e@gmx.net> writes:
> Please commit and wrap ahead.  IMO, the #ifdef DLLIMPORT should stay in
> sqlca.h, but the #ifdef __CYGWIN__ should probably outside of it (not
> inside).

Huh?  The macro has to get defined as *something* --- for non-CYGWIN
it must become defined as empty.  Jason's code looks OK to me.

I applied the patch as it stood ... if you think you can improve the
style then go ahead ...

            regards, tom lane

pgsql-cygwin by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Next
From: Jason Tishler
Date:
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch