Re: _WINSOCK_DEPRECATED_NO_WARNINGS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: _WINSOCK_DEPRECATED_NO_WARNINGS
Date
Msg-id 25237.1510890415@sss.pgh.pa.us
Whole thread Raw
In response to Re: _WINSOCK_DEPRECATED_NO_WARNINGS  (Glen Knowles <gknowles@ieee.org>)
List pgsql-hackers
Glen Knowles <gknowles@ieee.org> writes:
> On Thu, Nov 16, 2017 at 8:37 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> but evidently it chose the wrong cutoff for when to enable that
>> symbol, because woodlouse is (or claims to be) running VS2013.

> It's actually checking the wrong thing, the problem is the version of the
> Windows SDK, and while the one installed by default with VS2015 might be
> the right place to cutoff it's not uncommon to have multiple versions of
> the SDK (and VS) in various combinations.

Ah, interesting point --- though it's not clear that woodlouse is actually
running a mixture of SDK/VS releases.

> Or you could just define it unconditionally. :)

Already done that way.

I wonder though if this means the other tests of _MSC_VER in our tree
are wrong?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: [HACKERS] [PATCH] A hook for session start
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] Improve catcache/syscache performance.