Re: Returning NEW in an on-delete trigger - Mailing list pgsql-general

From Tom Lane
Subject Re: Returning NEW in an on-delete trigger
Date
Msg-id 25194.1221764683@sss.pgh.pa.us
Whole thread Raw
In response to Returning NEW in an on-delete trigger  ("Michael Nolan" <htfoot@gmail.com>)
Responses Re: Returning NEW in an on-delete trigger
List pgsql-general
"Michael Nolan" <htfoot@gmail.com> writes:
> Recently I discovered a coding error of mine in a trigger that is called
> only for deletes.
> I was returning NEW instead of OLD.
> Since NEW is undefined when deleting a row, it was failing and the row
> wasn't being deleted.
> However, it was failing silently.  Shouldn't this have recorded an error or
> warning somewhere?

The NEW variable is just set up as being NULL in an ON DELETE trigger,
likewise for OLD in an ON INSERT trigger.

This does seem like a bit of a gotcha for someone who writes RETURN NEW
instead of RETURN OLD or vice versa, but I'm not sure how much we can do
about that.  Lots of people like to write triggers that fire on multiple
event types, so we couldn't throw a syntax error for such a reference.
A runtime error for a use of the variable might be possible, but a quick
look at the code doesn't make it look easy.

            regards, tom lane

pgsql-general by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Returning NEW in an on-delete trigger
Next
From: Magnus Hagander
Date:
Subject: Re: Running initdb while logged in as Administrator user (Windows)