Re: stopping server does not remove external_pid_file - Mailing list pgsql-bugs

From Tom Lane
Subject Re: stopping server does not remove external_pid_file
Date
Msg-id 25099.1149648721@sss.pgh.pa.us
Whole thread Raw
In response to Re: stopping server does not remove external_pid_file  (Euler Taveira de Oliveira <euler@timbira.com>)
Responses Re: stopping server does not remove external_pid_file  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-bugs
Euler Taveira de Oliveira <euler@timbira.com> writes:
> Martin Pitt wrote:
>> I just played around with external_pid_file in 8.1.4. I noticed that
>> the file is created and filled properly, but it is not removed again
>> when the server is stopped.
>>
> Looking at the code I see this comment in
> src/backend/postmaster/postmaster.c

> /* Should we remove the pid file on postmaster exit? */

> IMHO, yes. It's not useful anymore.

[ shrug... ]  If the postmaster crashes, it would certainly fail to
remove the pidfile.  So I'd argue that your unnamed external script
that is expecting the pidfile to go away needs work: if it's not
verifying the PID given in the file, it's broken.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Euler Taveira de Oliveira
Date:
Subject: Re: stopping server does not remove external_pid_file
Next
From: Bruce Momjian
Date:
Subject: Re: stopping server does not remove external_pid_file