Re: aclchk.c refactor - Mailing list pgsql-patches

From Tom Lane
Subject Re: aclchk.c refactor
Date
Msg-id 2507.1132592260@sss.pgh.pa.us
Whole thread Raw
In response to Re: aclchk.c refactor  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-patches
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Now I noticed that there are multiple functions pg_class_aclmask,
> pg_database_aclmask, pg_language_aclmask, etc.  Is there any objection
> to making the exported routine expose the object type as an AclKind
> parameter instead of having one function for each object type?

How about "in addition to" instead of "instead"?  I see no reason to
impose extra notation and a level of indirection on the places that know
perfectly well which object type they are dealing with.

            regards, tom lane

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: aclchk.c refactor
Next
From: Tom Lane
Date:
Subject: Re: drop database if exists