Re: [BUGS] Server crash while trying to read expression using pg_get_expr() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [BUGS] Server crash while trying to read expression using pg_get_expr()
Date
Msg-id 25065.1276096031@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] Server crash while trying to read expression using pg_get_expr()  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> On 09/06/10 17:34, Tom Lane wrote:
>> I think #1 is a fool's errand.  There is far too much structure to a
>> node tree that is outside the scope of what readfuncs.c is capable of
>> understanding.

> That's why I said that ruleutils.c will need to understand and complain 
> about the rest.

And that's what I'm telling you is a hopeless task.

> Are you thinking we should retrict pg_get_expr() to superusers then?

I think that's the only solution that will actually fix the problem,
rather than lead to a never-ending series of security bugs.  In
hindsight we should never have exposed that function in that form.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: failover vs. read only queries
Next
From: Heikki Linnakangas
Date:
Subject: Re: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby