Postgres Pro
Downloads
Home   >   mailing lists

Re: Errno checks for rmtree() - Mailing list pgsql-patches

From Tom Lane
Subject Re: Errno checks for rmtree()
Date
Msg-id 25029.1108259781@sss.pgh.pa.us
Whole thread Raw
In response to Re: Errno checks for rmtree()  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Errno checks for rmtree()
List pgsql-patches
Tree view 
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> +     elog(WARNING, "can not remove \"%s\": %s", filepath, strerror(errno));

"could not remove", please; read the message style guidelines.
Also, what's wrong with using %m here?

Otherwise it looks good.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Errno checks for rmtree()
Next
From: Bruce Momjian
Date:
Subject: Re: Errno checks for rmtree()