pg_upgrade: Improve invalid option handling - Mailing list pgsql-hackers

Currently, calling pg_upgrade with an invalid command-line option aborts
pg_upgrade but leaves a pg_upgrade_internal.log file lying around.  This
patch reorder things a bit so that that file is not created until all
the options have been parsed.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services