Re: pg_dump doesn't dump new objects created in schemas from extensions - Mailing list pgsql-bugs

From Martín Marqués
Subject Re: pg_dump doesn't dump new objects created in schemas from extensions
Date
Msg-id 24a4d9cf-025d-d855-fe76-3af3f878174d@2ndquadrant.com
Whole thread Raw
In response to Re: pg_dump doesn't dump new objects created in schemas from extensions  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: pg_dump doesn't dump new objects created in schemas from extensions
Re: pg_dump doesn't dump new objects created in schemas from extensions
List pgsql-bugs
El 17/06/16 a las 03:35, Michael Paquier escribió:
> On Fri, Jun 17, 2016 at 4:21 AM, Martín Marqués <martin@2ndquadrant.com> wrote:
>> IMO, this assignment:
>>
>>                 tbinfo->dobj.dump = tbinfo->dobj.namespace->dobj.dump_contains;
>>
>> should be replaced by a call to some new function which would be more
>> or less a copy of selectDumpableNamespace, but without the
>> checkExtensionMembership call.
>
> Ah, I see. Yes this is definitely wrong. The namespace itself may be
> part of an extension but we do not check for it at all. See for
> example the patch attached that is giving what I would expect is the
> correct behavior.

This is a new version of your patch that checks for schema inclusion or
exclusion.

If there are no complains, I could apply similar changes on other
objects for a more complete patch.

Thoughts, objections?

--
Martín Marqués                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-bugs by date:

Previous
From: Jehan-Guillaume de Rorthais
Date:
Subject: Re: Segmentation fault with postgres -C external_pid_file
Next
From: "Albin, Lloyd P"
Date:
Subject: Re: BUG #14197: ERROR: character with byte sequence 0x81 in encoding "WIN1252" has no equivalent in encoding "UTF8"