Re: Non-portable shell code in pg_upgrade tap tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Non-portable shell code in pg_upgrade tap tests
Date
Msg-id 24992.1532196259@sss.pgh.pa.us
Whole thread Raw
In response to Re: Non-portable shell code in pg_upgrade tap tests  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
List pgsql-hackers
ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> Hmm.  Yeah, probably.  I don't think this script is meant to be run with
>> arbitrary values of PGDATA, but most of the other uses are quoted, so
>> for consistency's sake this should be too.

> Attached is a patch fixing this.  I checked the rest of the script, and
> this seems to be the only place lacking quoting.

Done already, but thanks.

            regards, tom lane


pgsql-hackers by date:

Previous
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Subject: Re: Non-portable shell code in pg_upgrade tap tests
Next
From: Charles Cui
Date:
Subject: Re: project updates