Re: syslogger line-end processing infelicity - Mailing list pgsql-hackers

From Tom Lane
Subject Re: syslogger line-end processing infelicity
Date
Msg-id 24952.1180737010@sss.pgh.pa.us
Whole thread Raw
In response to Re: syslogger line-end processing infelicity  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: syslogger line-end processing infelicity
Re: syslogger line-end processing infelicity
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> +1 on that.  The problem of ensuring atomic output remains though
>> (see nearby complaints from George Pavlov and others).

> Is that the one you suggested trying to fix by calling write() instead 
> of fprintf()? If so, I can't think of any good reason not to do that 
> anyway.

Probably not, but it doesn't fix the problem for long log lines (more
than PIPE_BUF bytes).

The other little problem (which is the reason we like the stderr
approach in the first place) is that not all the stderr output we want
to capture comes from code under our control.  This may not be a huge
problem in production situations, since the main issue in my experience
is being able to capture dynamic-linker messages when shlib loading fails.
But it is a stumbling block in the way of any proposals that involve
having a more structured protocol for the stuff going down the wire :-(
        regards, tom lane


pgsql-hackers by date:

Previous
From: Zdenek Kotala
Date:
Subject: Re: Command tags in create/drop scripts
Next
From: Tom Lane
Date:
Subject: Re: BufFileWrite across MAX_PHYSICAL_FILESIZE boundary