Re: pg_upgrade: Error out on too many command-line arguments - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_upgrade: Error out on too many command-line arguments
Date
Msg-id 24927.1567176468@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_upgrade: Error out on too many command-line arguments  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: pg_upgrade: Error out on too many command-line arguments  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> Is this issue *really* worth expending test cycles on forevermore?

> With this argument consistently applied, postgres code coverage is 
> consistently weak, with 25% of the code never executed, and 15% of 
> functions never called. "psql" is abysmal, "libpq" is really weak.

It's all a question of balance.  If you go too far in the other
direction, you end up with test suites that take an hour and a half
to run so nobody ever runs them (case in point, mysql).  I'm all for
improving coverage in meaningful ways --- but cases like this seem
unlikely to be worth ongoing expenditures of testing effort.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: pg_upgrade: Error out on too many command-line arguments
Next
From: Fabien COELHO
Date:
Subject: Re: refactoring - share str2*int64 functions