Re: should check collations when creating partitioned index - Mailing list pgsql-hackers

From Tom Lane
Subject Re: should check collations when creating partitioned index
Date
Msg-id 2491496.1699978510@sss.pgh.pa.us
Whole thread Raw
In response to Re: should check collations when creating partitioned index  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: should check collations when creating partitioned index
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> On 13.11.23 21:04, Laurenz Albe wrote:
>> This will be backpatched, right?  What if somebody already created an index like that?
>> Does this warrant an entry in the "however" for the release notes, or is the case
>> exotic enough that we can assume that nobody is affected?

> I think it's exotic enough that I wouldn't bother backpatching it.  But
> I welcome input on this.

I think it should be back-patched.

I don't love the patch details though.  It seems entirely wrong to check
this before we check the opclass match.  Also, in at least some cases
the code presses on looking for another match if the current opclass
doesn't match; you've broken such cases.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
Next
From: Peter Eisentraut
Date:
Subject: Re: Why do indexes and sorts use the database collation?