Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_dump -j against standbys - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump -j against standbys
Date
Msg-id 24912.1464186090@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump -j against standbys  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pg_dump -j against standbys  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tree view 
Magnus Hagander <magnus@hagander.net> writes:
>> Also, why didn't you keep using ExecuteSqlQueryForSingleRow()?

> The reason I did that is that ExecuteSqlQueryForSingleRow() is a static
> method in pg_dump.c. I was planning to go back and review that, and
> consider moving it, but I forgot it :S

> I think the clean thing is probably to use that one, and also move it over
> to not be a static method in pg_dump.c, but instead sit next to
> ExecuteSqlQuery in pg_backup_db.c. Do you agree that's reasonable, and
> something that's OK to backpatch?

No objection here, since it wouldn't be exposed outside pg_dump in any
case.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Does people favor to have matrix data type?
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied”