Re: BUG #4879: bgwriter fails to fsync the file in recovery mode - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Date
Msg-id 24885.1245951251@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #4879: bgwriter fails to fsync the file in recovery mode  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
List pgsql-bugs
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> Simon Riggs wrote:
>> On Thu, 2009-06-25 at 12:43 -0400, Tom Lane wrote:
>>> What about "revert the patch"?
>>
>> That's probably just as dangerous.

> I don't feel comfortable either reverting such a big patch at last
> minute.

Yeah, I'm not very happy with that either.  However, I've still got no
confidence in anything proposed so far.

> I'm testing the attached patch at the moment. It's the same as the
> previous one, with the elog() in mdsync() issue fixed.

This seems like a kluge on top of a hack.  Can't we have the bgwriter
do the final checkpoint instead?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Next
From: "Jeremy Ford"
Date:
Subject: BUG #4880: gcc (4.4) + double precision differences