Re: add label to enum syntax - Mailing list pgsql-hackers

From Tom Lane
Subject Re: add label to enum syntax
Date
Msg-id 24884.1288105202@sss.pgh.pa.us
Whole thread Raw
In response to Re: add label to enum syntax  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Andrew Dunstan's message of mar oct 26 10:54:59 -0300 2010:
>> Unlike the other suggestions, ELEMENT is not currently a keyword. That 
>> doesn't rule it out entirely, but it's a factor worth consideration.

> It can be added as an unreserved keyword, as in the attached patch.

> I also like ELEMENT better than the other suggestions, so I'm gonna
> commit this unless there are objections.

I definitely vote *against* adding a new keyword for this, unreserved or
otherwise.  Every keyword we add bloats the bison parser by some
fractional amount, costing performance across the board.

While I'm not very thrilled with LABEL, it at least has the virtue that
we already paid the price for it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: add label to enum syntax
Next
From: Jeff Janes
Date:
Subject: Re: xlog.c: WALInsertLock vs. WALWriteLock