Re: \crosstabview fixes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: \crosstabview fixes
Date
Msg-id 24706.1460580107@sss.pgh.pa.us
Whole thread Raw
In response to Re: \crosstabview fixes  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> (I also took the trouble to make the error messages conform
>> to project style.)

> Not sure about this part.  Many psql error messages are full sentences (start
> with uppercase, end in period); others start with the \ command being
> complained about.  Compare

> alvherre=# \foobar
> Invalid command \foobar. Try \? for help.
> alvherre=# \copy foobar
> \copy: parse error at end of line

Well, the first of those is meant to be two full sentences, though they
are a bit abbreviated.

I think putting "\crosstabview: " in front of all the error messages
in this patch would be a fine idea, though.  Will do that unless there
are further objections.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: \crosstabview fixes
Next
From: "Daniel Verite"
Date:
Subject: Re: [patch] \crosstabview documentation