Re: pgsql: Move Assert() definitions to c.h - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Move Assert() definitions to c.h
Date
Msg-id 24603.1359757680@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Move Assert() definitions to c.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Move Assert() definitions to c.h  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: pgsql: Move Assert() definitions to c.h  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Move Assert() definitions to c.h

This seems a bit odd.  Why didn't you move all of postgres.h's section 3
into the new section in c.h?  The couple of declarations you left there
are neither useful nor intelligible on their own.

Also, I think there's a typo here:

+#else /* USE_ASSERT_CHECKING && FRONTEND */

Should be

+#else /* USE_ASSERT_CHECKING && !FRONTEND */

no?

            regards, tom lane


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Move Assert() definitions to c.h
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Move Assert() definitions to c.h