Re: pgsql: Fix bug in Tid scan. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix bug in Tid scan.
Date
Msg-id 24554.1581123870@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix bug in Tid scan.  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: pgsql: Fix bug in Tid scan.  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-committers
Fujii Masao <masao.fujii@gmail.com> writes:
> On Sat, Feb 8, 2020 at 4:25 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> AFAICS, this patch has caused an ABI break in v12.  Do we really
>> believe that no extension references the values of the ScanOptions
>> enum?

> Yes, you are right. Some extensions may depend on it.
> It's better not to add new ScanOption not to break ABI.

I think it's okay to add a new value of ScanOption; what you can't
do is change the codes assigned to the existing values.  So I'd
just revert those code changes and give SO_TYPE_TIDSCAN a value
that's out-of-order.

            regards, tom lane



pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: pgsql: Fix bug in Tid scan.
Next
From: Fujii Masao
Date:
Subject: Re: pgsql: Fix bug in Tid scan.