Re: [COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid.
Date
Msg-id 24421.1340642102@sss.pgh.pa.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid.
List pgsql-hackers
Robert Haas <rhaas@postgresql.org> writes:
> Remove sanity test in XRecOffIsValid.

> Commit 061e7efb1b4c5b8a5d02122b7780531b8d5bf23d changed the rules
> for splitting xlog records across pages, but neglected to update this
> test.  It's possible that there's some better action here than just
> removing the test completely, but this at least appears to get some
> of the things that are currently broken (like initdb on MacOS X)
> working again.

Offhand, I'm wondering why this macro doesn't include a MAXALIGN test.
If it did, I don't think that the upper-limit test would have any
use anymore.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Ryan Kelly
Date:
Subject: Re: warning handling in Perl scripts
Next
From: "Kevin Grittner"
Date:
Subject: Re: Catalog/Metadata consistency during changeset extraction from wal