Postgres Pro
Downloads
Home   >   mailing lists

Re: Don't overwrite scan key in systable_beginscan() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Don't overwrite scan key in systable_beginscan()
Date
Msg-id 2440855.1723145284@sss.pgh.pa.us
Whole thread Raw
In response to Re: Don't overwrite scan key in systable_beginscan()  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Aug 8, 2024 at 2:46 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> I propose to fix that by making a copy of the scan keys passed by the
>> caller and make the modifications there.

> This does have the disadvantage of adding more palloc overhead.

It seems hard to believe that one more palloc + memcpy is going to be
noticeable in the context of an index scan.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: [18] Fix a few issues with the collation cache
Next
From: Nathan Bossart
Date:
Subject: Re: Proposal for Updating CRC32C with AVX-512 Algorithm.