Re: Deferred RI trigger for non-key UPDATEs and subxacts - Mailing list pgsql-patches

From Tom Lane
Subject Re: Deferred RI trigger for non-key UPDATEs and subxacts
Date
Msg-id 24389.1184687551@sss.pgh.pa.us
Whole thread Raw
In response to Re: Deferred RI trigger for non-key UPDATEs and subxacts  (Stephan Szabo <sszabo@megazone.bigpanda.com>)
Responses Re: Deferred RI trigger for non-key UPDATEs and subxacts
List pgsql-patches
Stephan Szabo <sszabo@megazone.bigpanda.com> writes:
> On Sun, 15 Jul 2007, Tom Lane wrote:
>> I don't think this is right.  If the original tuple was inserted by a
>> subtransaction of our transaction, it will have been checked at
>> subtransaction subcommit, no?

> I don't think the subtransaction subcommit will do the check. Unless I'm
> missing something about the code, a CommitTransaction would but a
> CommitSubTransaction won't, which actually makes sense given that we're
> mapping savepoints on to it, and I don't think we are allowed to check at
> savepoint release time.

OK, that's what I get for opining before checking the code ;-).  It
seems a little weird that a subcommitted subtransaction could still
cause a failure later, but that is how we're doing the triggers.

Given that, the proposed patch seems appropriate.  Will apply.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: WIP: rewrite numeric division
Next
From: Tom Lane
Date:
Subject: Re: WIP: rewrite numeric division