Re: cost_agg() with AGG_HASHED does not account for startup costs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: cost_agg() with AGG_HASHED does not account for startup costs
Date
Msg-id 24373.1438696491@sss.pgh.pa.us
Whole thread Raw
In response to cost_agg() with AGG_HASHED does not account for startup costs  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: cost_agg() with AGG_HASHED does not account for startup costs  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
David Rowley <david.rowley@2ndquadrant.com> writes:
> During working on allowing the planner to perform GROUP BY before joining
> I've noticed that cost_agg() completely ignores input_startup_cost
> when aggstrategy == AGG_HASHED.

Isn't your proposed patch double-counting the input startup cost?
input_total_cost already includes that charge.  The calculation
reflects the fact that we have to read all of the input before we
can deliver any aggregated results, so the time to get the first
input row isn't really interesting.

If this were wrong, the PLAIN costing path would also be wrong, but
I don't think that either one is.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Next
From: Heikki Linnakangas
Date:
Subject: Re: FSM versus GIN pending list bloat