Re: revised hstore patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: revised hstore patch
Date
Msg-id 2436.1248221582@sss.pgh.pa.us
Whole thread Raw
In response to Re: revised hstore patch  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Responses Re: revised hstore patch
Re: revised hstore patch
List pgsql-hackers
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> (b) many of the old names are significant collision risks.

What collision risks?  PG does not allow loadable libraries to export
their symbols, so I don't see the problem.  I recommend just keeping
those things named as they were.

> Certainly when developing this I had _SIGNIFICANT_ encouragement, some
> of it from YOU, for increasing the limit.

Yes, but that was before the interest in in-place upgrade went up.
This patch is the first place where we have to decide whether we meant
it when we said we were going to pay more attention to that.

> I'm prepared to give slightly more consideration to option #3: make
> the new code read the old format as well as the new one.

If you think you can make that work, it would solve the problem.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: revised hstore patch
Next
From: Jeff Davis
Date:
Subject: Re: revised hstore patch