Re: BUG #18770: The function 'packGraph ' causes a memory leak. - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #18770: The function 'packGraph ' causes a memory leak.
Date
Msg-id 2421469.1736520496@sss.pgh.pa.us
Whole thread Raw
In response to BUG #18770: The function 'packGraph ' causes a memory leak.  (PG Bug reporting form <noreply@postgresql.org>)
List pgsql-bugs
PG Bug reporting form <noreply@postgresql.org> writes:
> In line 1965 of the trgm_regexp.c file
> 1965:    arcs = (TrgmPackArcInfo *)
> 1966:        palloc(sizeof(TrgmPackArcInfo) * trgmNFA->arcsCount);
> The memory requested 'arcs' was not freed.

This is not a bug, unless you can show that the memory is allocated
in a long-lived context that won't get freed reasonably soon.  We
generally assume that letting memory context cleanup recover memory
is both faster and more oversight-proof than retail pfree calls.

In this particular case, it looks to me like the memory will come from
the temp context made by createTrgmNFA, and therefore will be freed
before that returns.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Asphator
Date:
Subject: Re: BUG #18663: synchronous_standby_names vs synchronous_commit vs pg_stat_replication
Next
From: PG Bug reporting form
Date:
Subject: BUG #18771: ICU custom collations with rules ignore collator strength option.