Re: strncmp->memcmp when we know the shorter length - Mailing list pgsql-hackers

From Tom Lane
Subject Re: strncmp->memcmp when we know the shorter length
Date
Msg-id 24181.1292991465@sss.pgh.pa.us
Whole thread Raw
In response to Re: strncmp->memcmp when we know the shorter length  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Dec 21, 2010 at 10:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm fairly uncomfortable about the broad swath and low return of this
>> patch. �Noah is assuming that none of these places are relying on
>> strncmp to stop short upon finding a null, and I don't believe that
>> that's a safe assumption in every single place. �Nor do I believe that
>> it's worth the effort of trying to prove it safe in most of those
>> places.

> Eh, I already committed somewhat more than that.  I did think about
> the concern which you raise.

Okay ... I was arguing for not bothering to expend that effort, but
since you already did, it's a moot point.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: bug in ts_rank_cd
Next
From: Alex Hunsaker
Date:
Subject: Re: plperlu problem with utf8