Re: pgsql: Don't archive bogus recycled or preallocated files after timelin - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Don't archive bogus recycled or preallocated files after timelin
Date
Msg-id 2414.1428967455@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Don't archive bogus recycled or preallocated files after timelin  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
Responses Re: pgsql: Don't archive bogus recycled or preallocated files after timelin  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-committers
Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
> To fix, whenever we switch to a new timeline, scan the data directory for
> WAL segments on the old timeline, but with a higher segment number, and
> remove them.

Wait a minute.  Didn't you just break PITR scenarios?  The *entire point*
of the multiple-timeline mechanism is that you can start a new WAL history
from a point in the past without destroying WAL history after that point
on the old timeline.

I've not read the patch, so maybe the code is all right, but this
description most certainly is not.

            regards, tom lane


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: pgbench: Attempt fix build on Windows
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Don't archive bogus recycled or preallocated files after timelin