Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path
Date
Msg-id 240582.1760370539@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path  (Bryan Green <dbryan.green@gmail.com>)
List pgsql-hackers
Tree view 
Bryan Green <dbryan.green@gmail.com> writes:
> I noticed that the log_error() utility function has a bug in its FRONTEND
> code path. The function uses fprintf() with a va_list argument, but
> fprintf() expects individual arguments. This should
> be vfprintf() instead.

Huh, that certainly appears broken, but isn't the non-FRONTEND
case equally broken?  write_stderr() doesn't expect a va_list
either.  I wonder if this code is ever reached at all.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Bryan Green
Date:
Subject: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path
Next
From: Jim Jones
Date:
Subject: Re: Add notification on BEGIN ATOMIC SQL functions using temp relations