Re: [PATCH] ident authentication fails on kFreeBSD/x86-64 due to wrong struct size - Mailing list pgsql-bugs

Martin Pitt <mpitt@debian.org> writes:
>      /* Compute size without padding */
> -    char        cmsgmem[ALIGN(sizeof(struct cmsghdr)) + ALIGN(sizeof(Cred))];    /* for NetBSD */
> +    char        cmsgmem[ALIGN(sizeof(struct cmsghdr)) + sizeof(Cred)];    /* for NetBSD */

Hm.  That code's been like that for a very long time (since 2001
according to the git history...).  How much confidence can we have
that this change won't result in breakage on other flavors of *BSD?

(I'm unable to test this myself, not having any platforms on which
this branch of auth_peer gets compiled...)

            regards, tom lane