Re: Is this a problem in GenericXLogFinish()? - Mailing list pgsql-hackers

On Mon, 2023-10-23 at 10:14 -0400, Robert Haas wrote:
> I think that would be a bug. I think it would be OK to just change
> the
> page LSN and nothing else, but that requires calling
> MarkBufferDirty()
> at some point. If you only call PageSetLSN() and never
> MarkBufferDirty(), that sounds messed up: either the former should be
> skipped, or the latter should be added. We shouldn't modify a shared
> buffer without marking it dirty.
>

In that case, I think REGBUF_NO_CHANGE is the right name for the flag.

Committed.

Regards,
    Jeff Davis