Re: GinPageIs* don't actually return a boolean - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GinPageIs* don't actually return a boolean
Date
Msg-id 23820.1455216330@sss.pgh.pa.us
Whole thread Raw
In response to Re: GinPageIs* don't actually return a boolean  (Andres Freund <andres@anarazel.de>)
Responses Re: GinPageIs* don't actually return a boolean
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2016-02-11 13:37:17 -0500, Tom Lane wrote:
>> Absolutely; they don't work safely for testing bits that aren't in the
>> rightmost byte of a flag word, for instance.  I'm on board with making
>> these fixes, I'm just unconvinced that stdbool is a good reason for it.

> Oh, ok. Interactions with stdbool was what made me looking into this,
> that's primarily why I mentioned it.   What's your thinking about
> back-patching, independent of that then?

Well, Yury was saying upthread that some MSVC versions have a problem
with the existing coding, which would be a reason to back-patch ...
but I'd like to see a failing buildfarm member first.  Don't particularly
want to promise to support compilers not represented in the farm.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Performance degradation in commit ac1d794
Next
From: Robbie Harwood
Date:
Subject: Re: [PATCH v4] GSSAPI encryption support