Re: m32r tas() implementation - Mailing list pgsql-ports

From Tom Lane
Subject Re: m32r tas() implementation
Date
Msg-id 23547.1176589025@sss.pgh.pa.us
Whole thread Raw
In response to m32r tas() implementation  (Martin Pitt <martin@piware.de>)
List pgsql-ports
Martin Pitt <martin@piware.de> writes:
> Kazuhiro Inaoka recently sent me a tas() implementation for the m32r
> architecture [1]. It applies cleanly to 8.2.3 and seems otherwise
> harmless. Do you consider applying it upstream?

The patch seems strongly dependent on an OS as well as a chip, since
<sys/tas.h> is hardly to be expected to exist everywhere.  Therefore,
it is at least short an #ifdef or so.  More generally I wonder if it's
not going at it backwards: if <sys/tas.h> exists, could we use it
regardless of CPU type?

            regards, tom lane

pgsql-ports by date:

Previous
From: Martin Pitt
Date:
Subject: m32r tas() implementation
Next
From: Kazuhiro Inaoka
Date:
Subject: Re: m32r tas() implementation