Re: WIN1252 encoding - backend or not? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: WIN1252 encoding - backend or not?
Date
Msg-id 23488.1102183198@sss.pgh.pa.us
Whole thread Raw
In response to WIN1252 encoding - backend or not?  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: WIN1252 encoding - backend or not?
List pgsql-hackers
"Magnus Hagander" <mha@sollentuna.net> writes:
> But further down we have:
> #define PG_ENCODING_BE_LAST PG_WIN1250

Scarier than that is grepping the source code for -i win125, and noting
the number of places that cover the existing WIN125[016] encodings but
fail to mention WIN1252.  In particular I notice that pg_wchar_table[]
in wchar.c has no entry added for WIN1252, which means that this patch
broke every encoding with higher code numbers.

Bruce, I think this patch has to come out.  We should not be in the
business of debugging a new feature post-RC1.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: WIN1252 encoding - backend or not?
Next
From: Bruce Momjian
Date:
Subject: Re: WIN1252 encoding - backend or not?