Re: crash in plancache with subtransactions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: crash in plancache with subtransactions
Date
Msg-id 23453.1287760788@sss.pgh.pa.us
Whole thread Raw
In response to Re: crash in plancache with subtransactions  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: crash in plancache with subtransactions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> On 22.10.2010 06:10, Tom Lane wrote:
>> (But on the third
>> hand, what are we gonna do for back-patching to versions without the
>> plancache?)

> One simple idea is to keep a flag along with the executor state to 
> indicate that the executor state is currently in use. Set it just before 
> calling ExecEvalExpr, and reset afterwards. If the flag is already set 
> in the beginning of exec_eval_simple_expr, we have recursed, and must 
> create a new executor state.

Yeah, the same thought occurred to me in the shower this morning.
I'm concerned about possible memory leakage during repeated recursion,
but maybe that can be dealt with.  I'll look into this issue soon,
though probably not today (Red Hat work calls :-().
        regards, tom lane


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Making OFF unreserved
Next
From: Dimitri Fontaine
Date:
Subject: Re: Extensions, this time with a patch