Re: BUG #2488: backup history file is archived doubly - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #2488: backup history file is archived doubly
Date
Msg-id 2337.1151002016@sss.pgh.pa.us
Whole thread Raw
In response to BUG #2488: backup history file is archived doubly  ("Masao Fujii" <fujii.masao@oss.ntt.co.jp>)
List pgsql-bugs
"Masao Fujii" <fujii.masao@oss.ntt.co.jp> writes:
> The cause of the problem is that pg_stop_backup creates two *.ready files.
> One file is created by pg_stop_backup > RemoveOldBackupHistory >
> XLogArchiveIsDone > XLogArchiveNotify.
> Another is created by pg_stop_backup > XLogArchiveNotify.

Oooh, good catch.  The cleanest solution would be to modify
RemoveOldBackupHistory so that it explicitly skips the current entry.
But I'm strongly tempted to just remove the code in pg_stop_backup,
and document that RemoveOldBackupHistory gets the job done (perhaps
renaming it).

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #2490: '||' and type casting for user defined types
Next
From: Tom Lane
Date:
Subject: Re: BUG #2486: PANIC when CTRL-C on vacuum full analyze