Re: Join push-down support for foreign tables - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Join push-down support for foreign tables
Date
Msg-id 23343.1418658355@sss.pgh.pa.us
Whole thread Raw
In response to Re: Join push-down support for foreign tables  (Shigeru Hanada <shigeru.hanada@gmail.com>)
Responses Re: Join push-down support for foreign tables  (Shigeru Hanada <shigeru.hanada@gmail.com>)
List pgsql-hackers
Shigeru Hanada <shigeru.hanada@gmail.com> writes:
> I'm working on $SUBJECT and would like to get comments about the
> design.  Attached patch is for the design below.  Note that the patch
> requires Kaigai-san's custom foriegn join patch[1]

For the record, I'm not particularly on-board with custom scan, and
even less so with custom join.  I don't want FDW features like this
depending on those kluges, especially not when you're still in need
of core-code changes (which really points up the inadequacy of those
concepts).

Also, please don't redefine struct NestPath like that.  That adds a
whole bunch of notational churn (and backpatch risk) for no value
that I can see.  It might've been better to do it like that in a
green field, but you're about twenty years too late to do it now.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Commit fest 2014-12, let's begin!
Next
From: Andres Freund
Date:
Subject: Re: Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS