Re: BUG #19095: Test if function exit() is used fail when linked static - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #19095: Test if function exit() is used fail when linked static
Date
Msg-id 2305435.1762929527@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #19095: Test if function exit() is used fail when linked static  (BharatDB <bharatdbpg@gmail.com>)
Responses Re: BUG #19095: Test if function exit() is used fail when linked static
List pgsql-bugs
BharatDB <bharatdbpg@gmail.com> writes:
>> [1]Changing the grep pattern to match the exact symbol ('grep -x exit')
>> prevents such false positives.

We might as well remove the test entirely as do that; it would
fail to detect "_exit" for example.

Additionally, I don't have a lot of faith in "grep -x" being
universally portable.  POSIX 2018 does specify that switch, but
it mentions that it is "historically available only with fgrep".

Personally I'm okay with whitelisting pthread_exit() as
Torsten suggested.

BTW, it looks like libpq's meson.build is missing this check.

            regards, tom lane



pgsql-bugs by date:

Previous
From: "Haiyang Li"
Date:
Subject: Re: BUG #19109: catalog lookup with the wrong snapshot during logical decoding causes coredump
Next
From: Richard Guo
Date:
Subject: Re: BUG #19106: Potential regression with CTE materialization planning in Postgres 18