Re: pgsql: doc: add examples of creative use of unique expression indexes - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: doc: add examples of creative use of unique expression indexes
Date
Msg-id 2304.1586532634@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: doc: add examples of creative use of unique expression indexes  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pgsql: doc: add examples of creative use of unique expressionindexes  (Bruce Momjian <bruce@momjian.us>)
List pgsql-committers
Bruce Momjian <bruce@momjian.us> writes:
> doc:  add examples of creative use of unique expression indexes
> https://git.postgresql.org/pg/commitdiff/a9760d0f3cb523336b5fdd9d6c5985e39a8588a1

We had a complaint [1] that this dropped an example into the middle of
two related paragraphs.  I agree with that objection, and also notice
that the extra example broke subsequent references to the "first example"
and "second example".  I'm also unhappy that the other addition that this
commit made was dropped inside Example 11.3; if we're going to use
<example> markup at all, each one ought to be a coherent entity.

On top of that, I don't find that either example actually adds anything
to the discussion, as the same points are being made in the existing
text.  Therefore, I don't think it's worth trying to fix these problems,
and propose just reverting this patch.

            regards, tom lane

[1] https://www.postgresql.org/message-id/158648685043.655.3074746555320970574%40wrigleys.postgresql.org



pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAPtest
Next
From: Tom Lane
Date:
Subject: pgsql: Suppress unused-variable warning.