Re: Cold welcoming message when installing anything because of LLVM bitcode stuff - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Cold welcoming message when installing anything because of LLVM bitcode stuff
Date
Msg-id 22982.1524938715@sss.pgh.pa.us
Whole thread Raw
In response to Cold welcoming message when installing anything because of LLVMbitcode stuff  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Cold welcoming message when installing anything because of LLVM bitcode stuff  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> JIT is introducing the installation of LLVM bitcode modules, and any
> installation done results in the following comment in output, which
> repeats basically for all the extensions installed:
> # Then install files
> #
> # The many INSTALL_DATA invocations aren't particularly fast, it'd be
> # good if we could coalesce them, but I didn't find a good way.

> Andres, could it be possible to move at least that block of comments in
> a place where this is not user-visible?

Agreed, there shouldn't be comments in the emitted shell commands;
I'm a bit surprised that works at all.  Close inspection of the
"make install" output revealed a few other issues, which I hope
I fixed rather than making things worse.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)
Next
From: Andres Freund
Date:
Subject: Re: Cold welcoming message when installing anything because of LLVM bitcode stuff