Re: MSVC buildfarm critters are not running modules' TAP tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: MSVC buildfarm critters are not running modules' TAP tests
Date
Msg-id 22859.1567986256@sss.pgh.pa.us
Whole thread Raw
In response to Re: MSVC buildfarm critters are not running modules' TAP tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: MSVC buildfarm critters are not running modules' TAP tests
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> I think that it is a good idea to add in subdircheck an extra path to
> check after TAP tests and run optionally these on top of the normal
> regression tests.  I have a couple of comments.

> Shouldn't we check after TAP_TESTS in the Makefile?

Yeah, perhaps, but I wasn't sure about how to do that easily.
Feel free to add it ...

> There is an argument to also check after isolation tests and run
> them.

Hm, yeah, if there are any such tests in those directories.

> The glob() part is a good idea in itself I think.  Why not
> back-patching it?  I could double-check it as well.

The whole thing should be back-patched into branches that have
any affected tests.  (But, please, not till after beta4 is
tagged.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
Next
From: Michael Paquier
Date:
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests