Re: gzgetc() is hazardous to your health - Mailing list pgsql-hackers

From Tom Lane
Subject Re: gzgetc() is hazardous to your health
Date
Msg-id 2264270.1760893036@sss.pgh.pa.us
Whole thread Raw
In response to gzgetc() is hazardous to your health  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> What I think we ought to do about this is get rid of our one usage
> of gzgetc(), replacing it with a one-byte gzread() operation.
> That's not lovely from a speed perspective, but I don't think that
> reading a pg_dump TOC file is really speed-critical.

In the light of morning I had a better, or at least easier, idea:
just #undef gzgetc and fall back on the underlying function.
That's at least a little faster than gzread(), too.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bryan Green
Date:
Subject: [PROPOSAL] Platform-native resource usage stats for Windows
Next
From: "Joel Jacobson"
Date:
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue