Re: warning when compiling utils/tqual.h - Mailing list pgsql-hackers

From Tom Lane
Subject Re: warning when compiling utils/tqual.h
Date
Msg-id 22461.1395075435@sss.pgh.pa.us
Whole thread Raw
In response to Re: warning when compiling utils/tqual.h  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: warning when compiling utils/tqual.h  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-03-17 12:50:37 -0400, Tom Lane wrote:
>> I guess the real question is why such a prototype is in tqual.h in
>> the first place.  ISTM this should be pushed somewhere specific to
>> reorderbuffer.c.  I'm -1 on having struct HTAB bleed into tqual.h
>> via either of the methods you suggest.

> It's the only logical decoding specific routine that's called by tqual.c
> which doesn't need anything else from reorderbuffer. I'd like to avoid
> more stuff bleeding in there...

Instead, you'd like HTAB to bleed into everything that uses tqual.h?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: warning when compiling utils/tqual.h
Next
From: Andres Freund
Date:
Subject: Re: warning when compiling utils/tqual.h