Re: pgAgent: C++ Port - Patch Review - Mailing list pgadmin-hackers

From Linreg
Subject Re: pgAgent: C++ Port - Patch Review
Date
Msg-id 2245391.nPH3ul8aAQ@wolfclan.ang.de
Whole thread Raw
In response to Re: pgAgent: C++ Port - Patch Review  (Dave Page <dpage@pgadmin.org>)
Responses Re: pgAgent: C++ Port - Patch Review
List pgadmin-hackers

Hi Dave,

>

> This change is unrelated to porting to pure C++, and needs to be

> discussed and (if acceptable) implemented as a separate patch. I'm not

> convinced it's an appropriate change at all - I certainly work with

> customer who do not use a connection pooler for various reasons, and

> rely on the pooler in the agent to prevent large numbers of

> connect/disconnect cycles, which amongst other things use resources

> unnecessarily, and can fill up audit logs.

A little addendum:

- connection pooling per Job is not a problem. This changes send i in the next week.

- connection pooling of all jobs has no effect in your code. The function clearconnection released connection-objects before it can be reused after one mainloop cycle. I think. I may be wrong.

so connection pooling per Job should be enough. What do you mean.

 

Thomas Steffen

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAgent: C++ Port - Patch Review
Next
From: Dave Page
Date:
Subject: Re: pgAgent: C++ Port - Patch Review