Re: wrong hint message for ALTER FOREIGN TABLE - Mailing list pgsql-hackers

Robert Haas <robertmhaas@gmail.com> writes:
> The sequence of steps that he posted wasn't actually right.

Yes, I did read the thread.

> The patch seems trivially correct,
> since this is obviously schizophrenic:

>           ereport(ERROR,
>                   (errcode(ERRCODE_WRONG_OBJECT_TYPE),
>                    errmsg("\"%s\" is not a foreign table",
> !                         RelationGetRelationName(targetrelation)),
> !                  errhint("Use ALTER FOREIGN TABLE instead.")));

Well, it's a pretty obvious global-search-and-replace error, but I fail
to see the advantage of just deleting the hint.  I was thinking

-             errhint("Use ALTER FOREIGN TABLE instead.")));
+             errhint("Use ALTER TABLE instead.")));

As per the other thread today, this advice would usually be correct,
so I think that not offering any advice at all would be a step down from
that.
        regards, tom lane