Re: [bug fix] "pg_ctl stop" times out when it should respond quickly - Mailing list pgsql-hackers

From Ronan Dunklau
Subject Re: [bug fix] "pg_ctl stop" times out when it should respond quickly
Date
Msg-id 2243350.MezRAmTkfY@ronan.dunklau.fr
Whole thread Raw
In response to Re: [bug fix] "pg_ctl stop" times out when it should respond quickly  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [bug fix] "pg_ctl stop" times out when it should respond quickly  ("MauMau" <maumau307@gmail.com>)
List pgsql-hackers
Le mardi 7 janvier 2014 17:05:03 Michael Paquier a écrit :
> On Sun, Jan 5, 2014 at 3:49 PM, MauMau <maumau307@gmail.com> wrote:
> > Could you confirm again and tell me what problem is happening?
>
> FWIW, I just quickly tested those two patches independently and got
> them correctly applied with patch -p1 < $PATCH on master at edc4345.
> They compiled and passed as well make check.
> Regards,

Both patches apply cleanly, I'll focus on the pg_stop_fail_v3 patch.

Tests are running correctly.

The bug this patch is supposed to fix has been reproduced on current HEAD, and
cannot be reproduced using the patch.

Previous concerns about using both get_pgpid and postmaster_is_alive are
adressed.

There is no regression tests covering this bugfix, althought I don't know if
it would be practical to implement them.


--
Ronan Dunklau
http://dalibo.com - http://dalibo.org

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: A better way than tweaking NTUP_PER_BUCKET
Next
From: Stephen Frost
Date:
Subject: Re: A better way than tweaking NTUP_PER_BUCKET