Re: Use of systable_beginscan_ordered in event trigger patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use of systable_beginscan_ordered in event trigger patch
Date
Msg-id 2243.1355272412@sss.pgh.pa.us
Whole thread Raw
In response to Re: Use of systable_beginscan_ordered in event trigger patch  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
Responses Re: Use of systable_beginscan_ordered in event trigger patch
List pgsql-hackers
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
> I don't remember that we fixed that case, I did attach a patch in the
> previous email, what do you think?

Yeah, I had forgotten about that loose end, but we definitely need
something of the sort.  Committed with additional documentation.
(I put something in the CREATE EVENT TRIGGER ref page, but do we
need anything about it in chapter 37?)

BTW, is the example in the CREATE EVENT TRIGGER ref page meant as an
IQ test for unwary readers?  You do know there are people who will
copy-and-paste just about any example that's put in front of them.
Perhaps we just want to make sure they internalize the advice about how
to get out of a broken-event-trigger situation.

Kidding aside, I think we need either a big WARNING, or a different
example.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader
Next
From: David Gould
Date:
Subject: Strange errors from 9.2.1 and 9.2.2 (I hope I'm missing something obvious)