Re: pgindent vs variable declaration across multiple lines - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent vs variable declaration across multiple lines
Date
Msg-id 2242842.1674574415@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent vs variable declaration across multiple lines  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgindent vs variable declaration across multiple lines
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-01-22 Su 17:34, Tom Lane wrote:
>> I've also attached a diff
>> representing the delta between what current pg_bsd_indent wants to do
>> to HEAD and what this would do.  All the changes it wants to make look
>> good, although I can't say whether there are other places it's failing
>> to change that we'd like it to.

> Changes look good. There are a handful of places where I think the code
> would be slightly more readable if a leading typecast were moved to the
> second line.

Possibly, but that's the sort of decision that pgindent leaves to human
judgment I think.  It'll reflow comment blocks across lines, but I don't
recall having seen it move line breaks within code.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Making Vars outer-join aware
Next
From: Robert Haas
Date:
Subject: Re: old_snapshot_threshold bottleneck on replica