Re: includeifexists in configuration file - Mailing list pgsql-hackers

From Tom Lane
Subject Re: includeifexists in configuration file
Date
Msg-id 22411.1321455258@sss.pgh.pa.us
Whole thread Raw
In response to Re: includeifexists in configuration file  (Euler Taveira de Oliveira <euler@timbira.com>)
List pgsql-hackers
Euler Taveira de Oliveira <euler@timbira.com> writes:
> On 16-11-2011 02:28, Greg Smith wrote:
>> By recent popular request in the ongoing discussion saga around merging the
>> recovery.conf, I've added an "includeifexists" directive to the
>> postgresql.conf in the attached patch.

> I'm not following the merging recovery.conf thread but isn't it worth emitting
> at least an WARNING message when the file does not exist?

> Something like

> WARNING:  could not open configuration file "/foo/missing.conf", skipping

Minor note here: people keep thinking that WARNING > LOG with respect to
messages that can only go to the server log.  This is not correct ...
LOG would be the right elevel to use.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: strict aliasing
Next
From: Peter Eisentraut
Date:
Subject: Re: ToDo: pg_backup - using a conditional DROP